Fix cpufreq event #712
Merged
Fix cpufreq event #712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r.stop() Emiting the current frequency of all CPUs in the stop() hook is not useful as the current frequency should already be known from the trace. Either the event is emitted every time the frequency changes and the up-to-date information is available, or the frequency never changes (e.g. userspace governor) and the frequencies will be known from emitting cpu_frequency_devlib in start().
…vents dependent on the configured events Make cpu_frequency_devlib dependent on whether the "cpu_frequency" event has been selected rather than dependent on the cpufreq devlib module being loaded on the target. The old behavior became particularly problematic with the lazy loading of modules. However, it was never a reliable way of knowing if the user was interested in the frequency or not. Apply a similar mechanism for the extra idle state transitions only done if "cpu_idle" event is selected.
|
Added the branch to our vendored version for dogfooding |
arjpur01
reviewed
Feb 25, 2025
| self._selected_events = selected_events | ||
|
|
||
| @property | ||
| def event_string(self): |
There was a problem hiding this comment.
why change event_string to property? what was the issue when it is a variable?
There was a problem hiding this comment.
It's derived from self._selected_events, leaving it as an attribute both clutters the state of the object with redundant information and also opens the door for mismatching content. Having it as a property makes the broken state impossible to represent.
arjpur01
approved these changes
Feb 25, 2025
arjpur01
approved these changes
Feb 25, 2025
marcbonnici
approved these changes
Mar 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.