Use VUL safe_struct #118
Open
Use VUL safe_struct #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solidpixel
force-pushed
the
vul_safe_struct
branch
from
cad35df to
2f12cdb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Vulkan API accepts a lot of const pointers to input structure trees, many of which have unstructured content due to the use of opaque pNext pointers to support extensions. Layers often want to change input data before calling down the stack, and the current code just uses const_cast on the inputs and modifies in place. This is obviously violating the API contract with the application so we need to fix it.
This PR will clone structure trees where needed, using the safe_struct library from the Vulkan Utility Libraries project.
Fixes #56