Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support default tz_module in event loop thread for M23/M33 #6978

Merged
merged 1 commit into from
Jun 11, 2018

Conversation

cyliangtw
Copy link
Contributor

Description

Thread class could support default tz_module of Thread attribute for M23/M33 in #6486 , however event loop & lwip will create new thread by osThreadNew(...) directly. So, to apply the same mechanism of #6486 on these 2 features. To allow event-queue's non-secure task to access secure functions.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@deepikabhavnani

Copy link

@deepikabhavnani deepikabhavnani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@cmonr
Copy link
Contributor

cmonr commented May 29, 2018

@SeppoTakalo @kjbracey-arm If y'all could check the two files, that would be great.

On quick glance, (and thank you for the referenced PR @cyliangtw) this looks fine to me.

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 7, 2018

/morph build

1 similar comment
@cmonr
Copy link
Contributor

cmonr commented Jun 7, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jun 7, 2018

Build : ABORTED

Build number : 2275
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6978/

@mbed-ci
Copy link

mbed-ci commented Jun 7, 2018

Build : ABORTED

Build number : 2279
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6978/

@cmonr
Copy link
Contributor

cmonr commented Jun 7, 2018

Halting CI builds until RC3 PRs are completed. Will resume after.

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 9, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jun 9, 2018

Build : SUCCESS

Build number : 2294
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6978/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jun 9, 2018

@mbed-ci
Copy link

mbed-ci commented Jun 9, 2018

@cmonr cmonr merged commit 3206b81 into ARMmbed:master Jun 11, 2018
@ccli8 ccli8 deleted the nuvoton_m23_tz_module branch December 20, 2018 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants