config: Add RAM1 memory region parameters to mbed_config.cmake #307
Conversation
Codecov Report
@@ Coverage Diff @@
## master #307 +/- ##
=======================================
Coverage 97.08% 97.08%
=======================================
Files 92 92
Lines 2776 2776
=======================================
Hits 2695 2695
Misses 81 81 |
rajkan01
force-pushed
the
update_mem_region_config_tmpl
branch
from
a7e26cd
to
06537db
Compare
Add ARM1 memory region defines to mbed_config.tmpl as most of the targets in targets.json has both RAM and RAM1 configurations
rajkan01
force-pushed
the
update_mem_region_config_tmpl
branch
from
06537db
to
ab4a1bc
Compare
| @@ -66,6 +66,12 @@ set(MBED_TARGET_DEFINITIONS{% for component in components %} | |||
| {%- endif %} | |||
| {% if mbed_ram_size is defined %} | |||
| MBED_RAM_SIZE={{ mbed_ram_size | to_hex }} | |||
| {%- endif %} | |||
| {% if mbed_ram1_start is defined %} | |||
| MBED_RAM1_START={{ mbed_ram1_start | to_hex }} | |||
There was a problem hiding this comment.
Do we need to also support MBED_RAM_2..MBED_RAM_N? https://github.com/ARMmbed/mbed-os/blob/master/targets/TARGET_STM/TARGET_STM32L4/TARGET_STM32L443xC/TOOLCHAIN_ARM/stm32l443xc.sct#L50 seems to want MBED_RAM2_* at least.
There was a problem hiding this comment.
Related question: I always wonder whether the naming/numbering rules are documented or everyone happens to use the same convention. How is Mbed CLI 1 handling this? (ignore this)
There was a problem hiding this comment.
@rwalton-arm Maybe it depends on whether we ever define mbed_ram2_start in targets.json?
Searching Mbed CLI 1 scripts (in mbed-os/tools/), there's only mbed_ram_start, not even ram1. So I wonder how (or if at all) MBED_RAM1_START is set by Mbed CLI 1. Maybe it's not set, and linker scripts fall back to #if !defined( and use hardcoded values for linking? (Worth checking)
Description
Fixes: #306
Add RAM1 memory region defines to mbed_config.tmpl as most of the targets
in targets.json has both RAM and RAM1 configurations
Test Coverage