-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Features/alignment optimization #96
Conversation
…_position and singular
I added a lot of tests to cover all raise blocks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The number of changed files seems to keep exponentially growing! This is definitely a huge contribution!
Thanks for all the changes - especially all the tests to cover errors and the additional unit tests make a huge difference. I also like the way the SurfaceConverter
is refactored.
I have included a few comments - most are minor points regarding DocStrings or things that we should maybe note as Issues to deal with later. I think the two important things are:
- A small suggestion to further refactor the
SurfaceConverter
. - Some notes on files being included from test coverage. I know they were previously excluded, but looking through the code I think there might still be some things we can test there.
I also noticed that the updated keys for the PAINT
data have not yet been included - we should probably update these (i.e. sun_azimuth
instead of Sun_azimuth
) and fix the test data before merging right?
Locally (I will push now) I have formatted the test .json
files to be "pretty" and also included a numbering for the alignment tutorial in the file name.
Thanks again for all the work - and sorry for the further requested changes...there are so many changes that I keep noticing new things when I review it again...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have made a few changes to the docstrings and test coverage locally which I will now push.
It looks good to me though - I am happy to allow the merge!
Features/alignment optimization
This branch mainly introduces the
AlignmentOptimizer
that can be used to optimize all 28 heliostat kinematic parameters. There are two optimization methods, one uses the motor positions and the other uses raytracing. Optimizing via the motor positions is significantly faster and also more accurate.This branch also changed other modules.
actuator_steps
,motor_steps
,actuator_pos
, ... all were referring to the same thing that is namedmotor_positions
in PAINT, thats why I chose that name for ARTIST as well.get_surface_points_and_surface_normals
method was moved from the alignement method to the init. This way it is only called once and not with each new alignment.PAINT_to_surface
converter was added to use PAINT data and create scenarios from it.Fixes #91
Type of change
Checklist: