-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#317 [feat] 엔티티 변경으로 인한 종합 일정 시간표 로직 리팩토링 #324
Merged
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
e394dac
#317 [chore] register dto 폴더 변경
sohyundoh bb6d9ef
#317 [chore] register dto 폴더 변경
sohyundoh cf40a1e
#317 [feat] Response Dto Class -> record
sohyundoh 35c0204
#317 [feat] retrieve dto 정의
sohyundoh fce20b5
#317 [feat] 종합 일정 시간표 로직 구현
sohyundoh 9e40ecf
#317 [test] 종합 일정 시간표 test 코드 작성
sohyundoh 4d6a61b
#317 [fix] weight 반영 안됨 오류 해결
sohyundoh e051ed4
#317 [chore] register dto 폴더 변경
sohyundoh cf752a8
#317 [test] 테스트 코드 수정
sohyundoh 1773755
#317 [refactor] TimeSlotRetrieve -> TimeBlock으로 변경
sohyundoh a5824c4
#317 [feat] 회의 참여자 조회 방식 변경
sohyundoh 45813c3
#317 [test] 불필요 stub 제거
sohyundoh f8b661e
#317 [feat] 미사용 메서드 제거
sohyundoh 2402bcb
#317 [refactor] 미사용 메서드 제거
sohyundoh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
21 changes: 21 additions & 0 deletions
21
src/main/java/com/asap/server/service/time/dto/retrieve/AvailableDatesRetrieveDto.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
package com.asap.server.service.time.dto.retrieve; | ||
|
||
import com.asap.server.common.utils.DateUtil; | ||
|
||
import java.time.LocalDate; | ||
import java.util.List; | ||
|
||
public record AvailableDatesRetrieveDto( | ||
String month, | ||
String day, | ||
String dayOfWeek, | ||
List<TimeSlotRetrieveDto> timeSlots | ||
) { | ||
public static AvailableDatesRetrieveDto of(final LocalDate date, final List<TimeSlotRetrieveDto> timeSlots) { | ||
return new AvailableDatesRetrieveDto( | ||
DateUtil.getMonth(date), | ||
DateUtil.getDay(date), | ||
DateUtil.getDayOfWeek(date), | ||
timeSlots); | ||
} | ||
} |
10 changes: 10 additions & 0 deletions
10
src/main/java/com/asap/server/service/time/dto/retrieve/TimeSlotRetrieveDto.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
package com.asap.server.service.time.dto.retrieve; | ||
|
||
import java.util.List; | ||
|
||
public record TimeSlotRetrieveDto( | ||
String time, | ||
List<String> userNames, | ||
int colorLevel | ||
) { | ||
} |
14 changes: 14 additions & 0 deletions
14
src/main/java/com/asap/server/service/time/dto/retrieve/TimeTableRetrieveDto.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
package com.asap.server.service.time.dto.retrieve; | ||
|
||
|
||
import java.util.List; | ||
|
||
public record TimeTableRetrieveDto( | ||
int memberCount, | ||
List<String> totalUserNames, | ||
List<AvailableDatesRetrieveDto> availableDateTimes | ||
) { | ||
public static TimeTableRetrieveDto of(final List<String> totalUserNames, final List<AvailableDatesRetrieveDto> availableDateTimes) { | ||
return new TimeTableRetrieveDto(totalUserNames.size(), totalUserNames, availableDateTimes); | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P5
지극히 개인적인 의견입니다.
현재 저희가 TimeSlot은 enum으로 정하고 있어서, TimeSlot이라 하니까 시간만 정의 되어 있는 느낌이 든다고 생각합니다..
그래서 TimeSlot 말고 TimeBlock이란 네이밍은 어떻게 생각하시나요??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
좋습니다!