simplify the masking API. #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
ASEM000
commented
Jan 25, 2024
ASEM000
commented
- remove freeze/unfreeze
- rename is_frozen to is_masked.
- restrict the cond in tree_mask to callable only
- remove freeze/unfreeze - rename is_frozen to is_masked. - restrict the cond in tree_mask to callable only
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #12 +/- ##
==========================================
- Coverage 94.47% 94.42% -0.05%
==========================================
Files 13 13
Lines 2334 2333 -1
==========================================
- Hits 2205 2203 -2
- Misses 129 130 +1 ☔ View full report in Codecov by Sentry. |
ASEM000
added a commit
that referenced
this pull request
Mar 30, 2024
* Shard info (#10) * add shard info in `tree_summary` for jax arrays (if exists) * add export xla flag in jax ci * shorter syntax * Update test_pprint.py * Simplify tree pprint (#11) * Update CHANGELOG.md * remove tree_mermaid tree_graph * simplify the masking API. (#12) * simplify the masking API. - remove freeze/unfreeze - rename is_frozen to is_masked. - restrict the cond in tree_mask to callable only * fix failing tests * remove partial is_tree_equal from public API * Update CHANGELOG.md * add __format__ * Update CHANGELOG.md * tree mask edits * add broadcast_to to bcmap (#13) * Remove distinction between regex and string match key (#14) * changelog edit * revert `__format__` * [AtIndexer] make string key points to regex by default, remove BaseKey * tree_*** -> *** * print tracer type in tree repr/str * fix `is_leaf` typing * revert #14 plus some mods - in favor of more explicit - fails if dicts haves keys similar to re.Pattern * remove __format__ * Add `fill_value` for `at[...].get(fill_value=...)` * bump version * changelog * Add `jax.tree_util.{SequenceKey,GetAttrKey,DictKey}` as valid path keys in `at[...]`. * define arraylib.array_equal * fix numpy test failing * AtIndexer -> at * tuple -> tuple[type1, ... typen] in tree_summary type row * add def_rule for at indexer * remove is_nondiff * docs organization * list tree summary pp rule * Update tree_mask.py * nits * fix at docstring * fix no leaf match error * fix doctest errors * docs * nits * typing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.