Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify convolutions #24

Merged
merged 3 commits into from
Jul 29, 2023
Merged

Unify convolutions #24

merged 3 commits into from
Jul 29, 2023

Conversation

ASEM000
Copy link
Owner

@ASEM000 ASEM000 commented Jul 29, 2023

Remove input dilation, rename kernel dilation to dilation

Simplified internals for FFT variants.

@codecov
Copy link

codecov bot commented Jul 29, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.19% 🎉

Comparison is base (4055028) 93.86% compared to head (12f43e0) 94.05%.

❗ Current head 12f43e0 differs from pull request most recent head 9d4c86b. Consider uploading reports for the commit 9d4c86b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #24      +/-   ##
==========================================
+ Coverage   93.86%   94.05%   +0.19%     
==========================================
  Files          40       40              
  Lines        3423     3332      -91     
==========================================
- Hits         3213     3134      -79     
+ Misses        210      198      -12     
Files Changed Coverage Δ
serket/nn/convolution.py 94.04% <ø> (-0.02%) ⬇️
serket/nn/dropout.py 92.78% <ø> (ø)
serket/nn/recurrent.py 83.83% <ø> (ø)
tests/test_fft_convolution.py 100.00% <ø> (ø)
serket/nn/utils.py 82.70% <100.00%> (+4.28%) ⬆️
tests/test_convolution.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ASEM000 ASEM000 merged commit 878803a into main Jul 29, 2023
9 checks passed
@ASEM000 ASEM000 deleted the unify-convolutions branch July 29, 2023 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant