Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch back to adding multiburst functionality to insar_tops_burst #242

Merged
merged 27 commits into from
Aug 23, 2024

Conversation

forrestfwilliams
Copy link
Contributor

@forrestfwilliams forrestfwilliams commented Aug 20, 2024

TODO:

  • Run a single-burst job and multi-burst job locally.

@forrestfwilliams forrestfwilliams requested a review from a team August 20, 2024 19:36
Copy link
Contributor

github-actions bot commented Aug 20, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
/home/runner/micromamba/envs/hyp3-isce2/lib/python3.11/site-packages/hyp3_isce2
   __main__.py26292%33, 44
   burst.py2505578%97–100, 113–118, 132–147, 163–172, 186–196, 254, 302–310, 330–344, 555–557, 583
   dem.py53394%101–110
   insar_stripmap.py755033%38–101, 105–107, 122–139
   insar_tops.py875932%48–101, 132–182, 204–222
   insar_tops_burst.py1359827%61–132, 143–197, 209–231, 235–237, 257–289
   logger.py4175%9
   merge_tops_bursts.py6299585%184, 201, 263, 268, 325, 341, 349, 381, 385, 471, 498, 576, 616–634, 683–691, 715, 720, 779, 802, 946, 1129–1149, 1164–1177, 1191–1217, 1228–1231, 1236–1249, 1253
   packaging.py19514327%46–48, 67–83, 120–218, 238–254, 274–284, 296–324, 336–338, 367–456, 460–466
   s1_auxcal.py21290%51, 59
   slc.py462057%23–30, 34–39, 50–56
   stripmapapp_alos.py50786%102, 138, 141–146
   topsapp.py70889%77, 107, 129–135
   utils.py1921095%109–120, 125, 203, 219–221, 228, 368, 413
   water_mask.py59592%88, 100–103
TOTAL191355871% 

Tests Skipped Failures Errors Time
81 0 💤 0 ❌ 0 🔥 30.810s ⏱️

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
tests/test_utils.py Outdated Show resolved Hide resolved
Copy link
Contributor

@jtherrmann jtherrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened #243 with some changes in addition to my comments above.

src/hyp3_isce2/utils.py Outdated Show resolved Hide resolved
tests/test_utils.py Outdated Show resolved Hide resolved
tests/test_utils.py Outdated Show resolved Hide resolved
tests/test_utils.py Outdated Show resolved Hide resolved
src/hyp3_isce2/burst.py Outdated Show resolved Hide resolved
src/hyp3_isce2/burst.py Outdated Show resolved Hide resolved
src/hyp3_isce2/burst.py Outdated Show resolved Hide resolved
src/hyp3_isce2/burst.py Outdated Show resolved Hide resolved
src/hyp3_isce2/burst.py Outdated Show resolved Hide resolved
src/hyp3_isce2/burst.py Outdated Show resolved Hide resolved
tests/test_burst.py Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
jtherrmann
jtherrmann previously approved these changes Aug 22, 2024
@jtherrmann jtherrmann dismissed their stale review August 22, 2024 22:28

Changes look good as far as I can tell, but we need to successfully run a multi-burst job (the example command from the README) locally before merging.

@forrestfwilliams
Copy link
Contributor Author

forrestfwilliams commented Aug 23, 2024

I've fixed the small date validation bug. I've also run all three following commands successfully and gotten the correct outputs:

python -m hyp3_isce2 ++process insar_tops_burst \
  S1_136231_IW2_20200604T022312_VV_7C85-BURST S1_136231_IW2_20200616T022313_VV_5D11-BURST \
  --looks 20x4 \
  --apply-water-mask True
python -m hyp3_isce2 ++process insar_tops_burst \
  --reference S1_136231_IW2_20200604T022312_VV_7C85-BURST \
  --secondary S1_136231_IW2_20200616T022313_VV_5D11-BURST \
  --looks 20x4 \
  --apply-water-mask True
python -m hyp3_isce2 ++process insar_tops_burst \
  --reference S1_136231_IW2_20200604T022312_VV_7C85-BURST S1_136232_IW2_20200604T022315_VV_7C85-BURST \
  --secondary S1_136231_IW2_20200616T022313_VV_5D11-BURST S1_136232_IW2_20200616T022316_VV_5D11-BURST \
  --looks 20x4 \
  --apply-water-mask True

@jtherrmann jtherrmann merged commit 0542044 into develop Aug 23, 2024
8 checks passed
@jtherrmann jtherrmann deleted the simplify branch August 23, 2024 17:47
@jtherrmann jtherrmann mentioned this pull request Aug 23, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants