Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update readme #292

Merged
merged 4 commits into from
Jan 10, 2024
Merged

Update readme #292

merged 4 commits into from
Jan 10, 2024

Conversation

forrestfwilliams
Copy link
Contributor

No description provided.

@forrestfwilliams forrestfwilliams requested a review from a team January 9, 2024 20:14
@forrestfwilliams forrestfwilliams added the bumpless Changes to documentation, CI/CD pipelines, etc that don't affect the project's version label Jan 9, 2024
jhkennedy
jhkennedy reviewed Jan 10, 2024
View reviewed changes
Copy link
Contributor

@jhkennedy jhkennedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I really like it! Well done.

I dropped a handful of small suggestions that I think are worth doing

@forrestfwilliams
Copy link
Contributor Author

Thanks! @jhkennedy this is ready for a re-review!

@forrestfwilliams forrestfwilliams merged commit 85b566b into develop Jan 10, 2024
7 of 8 checks passed
@forrestfwilliams forrestfwilliams deleted the readme branch January 10, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhkennedy jhkennedy jhkennedy approved these changes

Assignees
No one assigned
Labels
bumpless Changes to documentation, CI/CD pipelines, etc that don't affect the project's version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@forrestfwilliams @jhkennedy