-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy via AWS CDK #2479
Closed
Closed
Deploy via AWS CDK #2479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5b34c4f
to
b497d1b
Compare
b497d1b
to
7649527
Compare
7649527
to
dd6b9b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bumpless
Changes to documentation, CI/CD pipelines, etc that don't affect the project's version
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR demonstrates that it's possible to deploy via AWS CDK without converting any of our existing CF templates. We still don't know whether it's feasible to then incrementally convert stacks/resources to CDK or add new CDK resources using this approach.
Also see https://asfdaac.atlassian.net/browse/TOOL-3274
TODO:
cdk.json
(it was auto-generated viacdk init app --language python
per the hello world tutorial so could probably be refined)docs/deployments
, README, enterprise deployment wiki article, etc.)Notes:
For the GitHub Actions deployments, I created an IAM user with a policy allowing the following actions:
sts:AssumeRole
for each role created as part of the bootstrappedCDKToolkit
stacks3:PutObject
for thecf-templates
bucketssm:GetParameters
for all resources, which I think may be necessary for resolving theAmiId
parameter of typeAWS::SSM::Parameter::Value<AWS::EC2::Image::Id>
inmain-cf.yml.j2
I didn't specifically search the AWS CDK docs to see if they document the recommended IAM policy to use for automated deployments.
Wrapping up: