Skip to content

fix(app-webdir-ui): fix short bio not appearing in web directory #1588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
+13 −8
Open

fix(app-webdir-ui): fix short bio not appearing in web directory #1588

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions packages/app-webdir-ui/src/ProfileCard/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,12 @@ import { profileCardType } from "./models";
*/

const ProfileCard = ({ ...props }) => {
const hasSocialsOrWebsite =
const hasSocialsOrWebsiteOrShortBio =
props.facebookLink ||
props.linkedinLink ||
props.twitterLink ||
props.website;
props.website ||
props.shortBio;
const title = props.matchedAffiliationTitle
? `${props.matchedAffiliationTitle}`
: "";
Expand Down Expand Up @@ -136,7 +137,7 @@ const ProfileCard = ({ ...props }) => {
)}
</ul>
)}
{["default", "large"].includes(props.size) && hasSocialsOrWebsite && (
{["default", "large"].includes(props.size) && hasSocialsOrWebsiteOrShortBio && (
<div className="description-and-social">
<p className="person-description">
{props.shortBio?.slice(0, 250)}
Expand Down
14 changes: 9 additions & 5 deletions packages/app-webdir-ui/src/WebDirectoryComponent/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
// @ts-check
/* eslint no-use-before-define: 0 */
import PropTypes from "prop-types";
import React, { useState, useEffect } from "react";

Expand All @@ -24,7 +23,7 @@ import { WebDirLayout, FacultyRankLayout } from "./index.styles";
* @param {string} props.searchApiVersion - The version of the search API to use.
* @param {string} props.profileURLBase - The base URL for profile links.
* @param {string} props.appPathFolder - The base path for the application folder.
* @param {object} props.display - Display options for the search results.
* @param {Record<string, any>} props.display - Display options for the search results.
* @param {Object} props.filters - Filters for the search.
* @param {string} props.alphaFilter - Indicates whether to enable alpha filtering.
* @returns {JSX.Element} The WebDirectory component.
Expand All @@ -45,7 +44,7 @@ function WebDirectory({
const [sort, setSort] = useState(defaultSortSetter);
const [requestFilters, setRequestFilters] = useState(doSearch);
const [gridView, setGridView] = useState(
display.grid === "true" || display.grid === true
display?.grid === "true" || display?.grid === true
);
const RES_PER_PAGE = 6;

Expand All @@ -65,6 +64,7 @@ function WebDirectory({

// Initializer functions for requestFilters and sort. Only runs on first render.
function doSearch() {
/** @type {Record<string, any>} */
const tempFilters = filters ? { ...filters } : {};
if (searchType === "departments" || searchType === "faculty_rank") {
tempFilters["deptIds"] = deptIds.split(",");
Expand Down Expand Up @@ -96,7 +96,11 @@ function WebDirectory({
return "last_name_asc"; // defaults to last_name_asc if no default sort is set in CMS
}

// Function returns an array of custom sort options based on the webDirSearchType and departmentIds parameters.
/**
* Function returns an array of custom sort options based on the webDirSearchType and departmentIds parameters.
* @param {string} webDirSearchType
* @param {string} departmentIds
*/
function sortOptionsFunc(webDirSearchType, departmentIds) {
if (
webDirSearchType === "departments" &&
Expand Down Expand Up @@ -139,7 +143,7 @@ function WebDirectory({
...engineParams,
},
[engineNames.WEB_DIRECTORY_FACULTY_RANK]: {
...engines[engineNames.WEB_DIRECTORY_FACULTY__RANK],
...engines[engineNames.WEB_DIRECTORY_FACULTY_RANK],
...engineParams,
deptIds,
display,
Expand Down