Update packages: torch and lightning #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st step (2) torchmetrics: Add Precision@k, Recall@k
…back (deprecated)
…r. (2) use ray[tune] instead of ray.
…py: Put comments and remove unused import.
4 tasks
Eleven1Liu
changed the title
Eleven1Liu
requested review from
cjlin1,
henryyang42,
JamesLYC88 and
Gordon119
as code owners
|
Since LibMultiLabel implemented all the metrics itself, I think there is no need to use fixed version for torchmetrics. >= 1.0.0 would be better. |
|
Hi Eleven. How about we upgrade lightning first if this PR will take more time to get approved? |
4 tasks
Eleven1Liu
force-pushed
the
update_pkgs
branch
from
357c324 to
5947a68
Compare
Gordon119
approved these changes
Feb 9, 2024
Eleven1Liu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update packages:
Test CLI & API (
bash tests/autotest.sh)Test APIs used by main.py.
Check API Document
If any new APIs are added, please check if the description of the APIs is added to API document.
Test quickstart & API (
bash tests/docs/test_changed_document.sh)If any APIs in quickstarts or tutorials are modified, please run this test to check if the current examples can run correctly after the modified APIs are released.