Feature/all katas #19

jpaitken · 2017-06-28T13:21:23Z

Mine

…llKatas

carledriss · 2017-06-29T15:13:22Z

src/main/java/org/fundacionjala/coding/juan/bank/BankOCR.java

+ */
+public final class BankOCR {
+
+    private static Map<Integer, String> mapNum = new HashMap<>();


this should be final

carledriss · 2017-06-29T15:14:34Z

src/main/java/org/fundacionjala/coding/juan/eanvalidator/EanValidator.java

+        final int finalFactor = 10;
+        final int aux = 48;
+        for (int i = 0; i < finalNumber; i++) {
+            if (i % 2 != 0) {


Instead of using an if else
Consider using a ternary condition.

carledriss · 2017-06-29T15:15:19Z

src/main/java/org/fundacionjala/coding/juan/gas/Evaporator.java

+    public int evaporator(final double content, final int evap, final int threshold) {
+        int days = 0;
+        double waste1;
+        double limit1 = content * threshold / 100.00;


Do we need this variable?

carledriss · 2017-06-29T15:15:48Z

src/main/java/org/fundacionjala/coding/juan/gas/Evaporator.java

+        double limit1 = content * threshold / 100.00;
+        double conte = content;
+        while (conte >= limit1) {
+            waste1 = conte * evap / 100.00;


Do we need this variable?

carledriss · 2017-06-29T15:16:47Z

src/main/java/org/fundacionjala/coding/juan/spinWords/SpinWords.java

+     * @param  sentence is the word or words
+     * @return the word spined.
+     */
+    public static  String spinWords(final String sentence) {


A lot of code. :(
Try to refactor it

carledriss · 2017-06-29T15:17:45Z

src/test/java/org/fundacionjala/coding/juan/movies/NewReleaseTest.java

+    public void testNewRealeasenMovieAmount() {
+
+        // given:
+        final NewRelease newRelease = new NewRelease("Logan");


this should be

final Movie newRelease = new NewRelease("Logan");

Apply in all your unit tests

carledriss · 2017-06-29T15:18:42Z

coding.iml

@@ -0,0 +1,12 @@
+<?xml version="1.0" encoding="UTF-8"?>


remove this unnecessary file

…e/allKatas

Coverage 80%

codecov-io · 2017-07-01T22:45:09Z

Codecov Report

Merging #19 into develop will increase coverage by 0.3%.
The diff coverage is 95.67%.

@@             Coverage Diff              @@
##             develop      #19     +/-   ##
============================================
+ Coverage      94.78%   95.09%   +0.3%     
- Complexity       138      210     +72     
============================================
  Files             26       39     +13     
  Lines            307      469    +162     
  Branches          50       73     +23     
============================================
+ Hits             291      446    +155     
- Misses             5        6      +1     
- Partials          11       17      +6

Impacted Files	Coverage Δ	Complexity Δ
...g/fundacionjala/coding/juan/test/ArrayAverage.java	`100% <100%> (ø)`	`6 <6> (?)`
...fundacionjala/coding/juan/spinWords/SpinWords.java	`100% <100%> (ø)`	`5 <5> (?)`
...coding/juan/multiplesof3and5/MultiplesOf3And5.java	`100% <100%> (ø)`	`5 <5> (?)`
...oding/juan/highestandlowest/HightestAndLowest.java	`100% <100%> (ø)`	`3 <3> (?)`
...org/fundacionjala/coding/juan/movies/Customer.java	`100% <100%> (ø)`	`8 <8> (?)`
...va/org/fundacionjala/coding/juan/movies/Movie.java	`100% <100%> (ø)`	`2 <2> (?)`
...org/fundacionjala/coding/juan/movies/Children.java	`100% <100%> (ø)`	`4 <4> (?)`
.../org/fundacionjala/coding/juan/movies/Regular.java	`100% <100%> (ø)`	`4 <4> (?)`
.../org/fundacionjala/coding/juan/gas/Evaporator.java	`100% <100%> (ø)`	`3 <3> (?)`
...a/org/fundacionjala/coding/juan/movies/Rental.java	`100% <100%> (ø)`	`5 <5> (?)`
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 112c303...8209bc7. Read the comment docs.

Coverage 90%

carledriss · 2017-07-03T12:43:31Z

src/main/java/org/fundacionjala/coding/juan/eanvalidator/EanValidator.java

+            if (i % 2 != 0) {
+                sum += ((eanCode.charAt(i) - aux) * multiply);
+            } else {
+                sum += (eanCode.charAt(i) - aux);


you can use a ternary condition here

carledriss · 2017-07-03T12:44:09Z

src/main/java/org/fundacionjala/coding/juan/spinWords/SpinWords.java

+     * @param sentence is the word or words
+     * @return the word spined.
+     */
+    public static String spinWords(final String sentence) {


please refactor this code

carledriss · 2017-07-03T12:44:54Z

src/test/java/org/fundacionjala/coding/juan/gas/EvaporatorTest.java

+ * Created by Administrator on 6/28/2017.
+ */
+public class EvaporatorTest {
+    private Evaporator evaporator = new Evaporator();


this is a bad practice

carledriss · 2017-07-03T12:45:07Z

src/test/java/org/fundacionjala/coding/juan/highestandlowest/HightesAndLowestTest.java

+ * Created by Administrator on 6/28/2017.
+ */
+public class HightesAndLowestTest {
+    private HightesAndLowest hightesAndLowest = new HightesAndLowest();


this is a bad practice

carledriss · 2017-07-03T12:45:54Z

src/main/java/org/fundacionjala/coding/juan/bank/BankOCR.java

+/**
+ * Created by Juan Pablo on 26/03/2017.
+ */
+public final class BankOCR {


This solution is not completed

carledriss · 2017-07-07T01:16:38Z

src/main/java/org/fundacionjala/coding/juan/movies/Customer.java

+
+        for (Rental rental : rentalsCustomer) {
+
+            result += String.format("%s  ", rental.getMovie().getTitle());


@AT-03/at-03
what is wrong here?

carledriss · 2017-07-07T01:17:15Z

src/main/java/org/fundacionjala/coding/juan/spinWords/SpinWords.java

+     * @param sentence is the word or words
+     * @return the word reversed.
+     */
+    public static String spinWords(final String sentence) {


you can still improve this method.

carledriss · 2017-07-07T01:17:39Z

src/test/java/org/fundacionjala/coding/juan/bank/BankOCRTest.java

+        String account = "021453789";
+
+        // when:
+        String expectedResult = "ERR";


carledriss · 2017-07-07T01:17:45Z

src/test/java/org/fundacionjala/coding/juan/bank/BankOCRTest.java

+        String[] accountArray = BankOCR.parseScannedFigures(figureScanned);
+
+        // when:
+        String actualResult = BankOCR.accountRepresentation(accountArray);


carledriss · 2017-07-07T01:18:23Z

src/test/java/org/fundacionjala/coding/juan/bank/BankOCRTest.java

+     * Testing an invalid account.
+     */
+    @Test
+    public void verifyValidateAccountNumbersFalse() {


@AT-03/at-03
all your unit tests should start with the prefix test not verify

carledriss · 2017-07-07T01:19:40Z

src/test/java/org/fundacionjala/coding/juan/movies/RentalTest.java

+     * Initialize variables.
+     */
+    @Before
+    public void initialize() {


@AT-03/at-03
Consider using setUp instead of initialize

carledriss · 2017-07-07T01:19:55Z

src/test/java/org/fundacionjala/coding/juan/multiplesof3and5/MultiplesOf3And5Test.java

+ * Created by Administrator on 6/28/2017.
+ */
+public class MultiplesOf3And5Test {
+    private MultiplesOf3And5 kata = new MultiplesOf3And5();


@AT-03/at-03
what is wrong here?

carledriss · 2017-07-08T16:42:35Z

src/main/java/org/fundacionjala/coding/juan/eanvalidator/EanValidator.java

+        int checkSum = 0;
+        int digit = 0;
+        for (int i = 0; i < code.length; i++) {
+            digit = (code[i]);


remove unnecessary parenthesis

carledriss · 2017-07-08T16:42:40Z

src/main/java/org/fundacionjala/coding/juan/eanvalidator/EanValidator.java

+        int digit = 0;
+        for (int i = 0; i < code.length; i++) {
+            digit = (code[i]);
+            checkSum += ((i + 1) % 2 == 0) ? digit * 3 : digit;


remove unnecessary parenthesis

carledriss · 2017-07-08T16:43:07Z

src/main/java/org/fundacionjala/coding/juan/gas/Evaporator.java

+        double cont = content;
+        double limit1 = content * threshold / 100.00;
+        while (cont >= limit1) {
+            cont = cont - cont * evap / 100.00;


please refactor this line of code

carledriss · 2017-07-08T16:43:38Z

src/main/java/org/fundacionjala/coding/juan/movies/NewRelease.java

+    public NewRelease(final String title) {
+        super(title);
+    }
+


{@inherentDoc}

carledriss · 2017-07-08T16:43:47Z

src/main/java/org/fundacionjala/coding/juan/movies/Regular.java

+
+    @Override
+    public int calculateFrequentRenterPoints(final int daysRented) {
+        return 1;


use a constant

carledriss · 2017-07-08T16:44:43Z

src/test/java/org/fundacionjala/coding/juan/bank/BankOCRTest.java

+                "       _  _  _  _  _  _  _ "
+                        + "  ||_||_||_||_| _";
+        // when:
+        final Boolean actualResult = BankOCR.validateAccountNumbers(figureScanned);


why are using the Boolean class?
you should use the primitive boolean

carledriss · 2017-07-08T16:45:38Z

src/test/java/org/fundacionjala/coding/juan/movies/RentalTest.java

+ * Created by Administrator on 7/2/2017.
+ */
+public class RentalTest {
+    private Regular regular;


What is wrong here?

carledriss · 2017-07-11T23:45:15Z

src/main/java/org/fundacionjala/coding/juan/bank/BankOCR.java

+     * @param account account.
+     * @return true or false.
+     */
+    static boolean isLegible(final String account) {


you can still refactor this

jpaitken added 14 commits March 10, 2017 11:19

commit1

7d86ee0

commit2 with gradle check

772d31e

Delete bank_Machinne.java

431fc30

Update EanValidator.java

0770a7a

commit3

667db53

commit MOVIES

175b1fd

commit 26/3

ebd41d3

Commit Test

93f81bf

BankCommit - firts

4081f11

katas

3800786

All Katas

4349bce

Merge branch 'develop' into feature/allKatas

d6953c2

All Katas

268d209

Merge remote-tracking branch 'origin/feature/allKatas' into feature/a…

dae303b

…llKatas

carledriss reviewed Jun 29, 2017

View reviewed changes

coding.iml Outdated

@@ -0,0 +1,12 @@

<?xml version="1.0" encoding="UTF-8"?>

Copy link

Contributor

carledriss Jun 29, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this unnecessary file

jpaitken added 2 commits July 1, 2017 16:41

Merge branch 'develop' of https://github.com/AT-03/coding into featur…

7670dc4

…e/allKatas

Code improved

6e0be4e

Coverage 80%

Code improved

19a464d

Coverage 90%

carledriss reviewed Jul 3, 2017

View reviewed changes

carledriss reviewed Jul 7, 2017

View reviewed changes

jpaitken added 3 commits July 7, 2017 11:31

improved

501fbd5

improved

e4aebe2

improved

0f878af

carledriss reviewed Jul 8, 2017

View reviewed changes

jpaitken and others added 12 commits July 8, 2017 16:52

fixes

444945d

fixes

7495ae9

fixes

fcc4b17

fixes

11b3181

fixes

63eacc6

fixes

ad53230

fixes

8a3d26c

fixes

8700259

fixes

b6a567e

fixes

19d0968

fixes

2263a52

fixes

8209bc7

carledriss reviewed Jul 11, 2017

View reviewed changes


		for (Rental rental : rentalsCustomer) {

		result += String.format("%s ", rental.getMovie().getTitle());

Feature/all katas #19

Are you sure you want to change the base?

Feature/all katas #19

Uh oh!

Conversation

jpaitken commented Jun 28, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov-io commented Jul 1, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

carledriss Jul 7, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

carledriss Jul 7, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov-io commented Jul 1, 2017 •

edited

Loading

carledriss Jul 7, 2017 •

edited

Loading

carledriss Jul 7, 2017 •

edited

Loading