Katanorman #30
Katanorman #30
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #30 +/- ##
=============================================
+ Coverage 94.78% 96.17% +1.38%
- Complexity 138 205 +67
=============================================
Files 26 43 +17
Lines 307 444 +137
Branches 50 64 +14
=============================================
+ Hits 291 427 +136
Misses 5 5
- Partials 11 12 +1
Continue to review full report at Codecov.
|
| /** | ||
| * method fill number digite. | ||
| */ | ||
| public void fillNumber() { |
There was a problem hiding this comment.
@666nonak666
Instead of having this method
you can have a static attribute.
Review again
| /** | ||
| * Created by NORMAN on 2/7/2017. | ||
| */ | ||
| public class HistoryOneBankOcr extends FileNumberBankOcr { |
There was a problem hiding this comment.
@AT-03/at-03
We don't here inheritance
Please have a single class for BankOCR
| * | ||
| * @param daysRented of int type. | ||
| * @return the amount of a new release rented movie. | ||
| */ |
There was a problem hiding this comment.
@AT-03/at-03
you should use
/**
* {@inherentDoc}
*/
|
|
||
| // when: | ||
| HistoryOneBankOcr bankOcr = new HistoryOneBankOcr(); | ||
| String actualResult = bankOcr.verificationLineNumber(insertLineFour); |
| ); | ||
|
|
||
| // when: | ||
| HistoryOneBankOcr bankOcr = new HistoryOneBankOcr(); |
There was a problem hiding this comment.
You are repeating this line in all your tests
Please move it in a @before method
| @Test | ||
| public void testCalculateAmountWhenTheRentedDaysIsLessThanThree() { | ||
| // given: | ||
| NewRelease newReleaseInstance = new NewRelease("Test"); |
There was a problem hiding this comment.
@AT-03/at-03
what is wrong here
|
|
||
| // then | ||
| final double expectedResult = 3; | ||
| assertEquals(0, expectedResult, actualResult); |
There was a problem hiding this comment.
@AT-03/at-03
What is wrong here?
|
|
||
| // when: | ||
| final double actualResult = newReleaseInstance.calculateAmount(10); | ||
|
|
||
| // then: | ||
| final double expectedResult = 30; | ||
| assertEquals(0, expectedResult, actualResult); | ||
| assertTrue(expectedResult - actualResult == 0); |
There was a problem hiding this comment.
you should use an assertEquals
No description provided.