Skip to content

Commit

Permalink
updated to node 20
Browse files Browse the repository at this point in the history
added nvmrc file

Signed-off-by: Noam Gal <[email protected]>
  • Loading branch information
ATGardner committed Aug 21, 2023
1 parent a2435c5 commit 10b7a16
Show file tree
Hide file tree
Showing 8 changed files with 22 additions and 52 deletions.
2 changes: 1 addition & 1 deletion .devcontainer/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

# To fully customize the contents of this image, use the following Dockerfile instead:
# https://github.com/microsoft/vscode-dev-containers/tree/v0.128.0/containers/javascript-node-14/.devcontainer/Dockerfile
FROM mcr.microsoft.com/vscode/devcontainers/javascript-node:18
FROM mcr.microsoft.com/vscode/devcontainers/javascript-node:20

# ** [Optional] Uncomment this section to install additional packages. **
#
Expand Down
2 changes: 1 addition & 1 deletion .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// For format details, see https://aka.ms/vscode-remote/devcontainer.json or this file's README at:
// https://github.com/microsoft/vscode-dev-containers/tree/v0.128.0/containers/javascript-node-14
{
"name": "Node.js 18",
"name": "Node.js 20",
"dockerFile": "Dockerfile",

// Set *default* container specific settings.json values on container create.
Expand Down
1 change: 1 addition & 0 deletions .nvmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
v20.5.1
8 changes: 5 additions & 3 deletions .vscode/launch.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,18 +26,20 @@
"cmd",
"--",
"getRelation",
"282071",
// "282071", // int
"13137517", // old int
"-s",
"0",
"-m",
"1000",
"--reverse",
// "--reverse",
],
"runtimeExecutable": "npm",
"skipFiles": [
"<node_internals>/**"
],
"type": "node"
"type": "node",
"runtimeVersion": "20.5.1"
},
{
"type": "node",
Expand Down
2 changes: 1 addition & 1 deletion docker/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:18-alpine
FROM node:20-alpine

LABEL maintainer="Noam \"Amtrak\" Gal"

Expand Down
2 changes: 1 addition & 1 deletion docker/dev.Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:18-alpine
FROM node:20-alpine

LABEL maintainer="Noam \"Amtrak\" Gal"

Expand Down
56 changes: 12 additions & 44 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
"eslint-plugin-node": "^11.1.0",
"eslint-plugin-prettier": "^5.0.0",
"eslint-plugin-promise": "^6.1.1",
"eslint-plugin-standard": "^5.0.0",
"mocha": "^10.2.0",
"prettier": "^3.0.2"
},
Expand Down

0 comments on commit 10b7a16

Please sign in to comment.