Add more tests

ATIX-AG · Apr 8, 2024 · 286c623 · 286c623
1 parent c841fd7
commit 286c623
Show file tree

Hide file tree

Showing 5 changed files with 4,776 additions and 7 deletions.
diff --git a/.rubocop.yml b/.rubocop.yml
@@ -26,6 +26,12 @@ Metrics/ClassLength:
 Metrics/MethodLength:
   Max: 20
 
+Metrics/CyclomaticComplexity:
+  Max: 10
+
+Metrics/PerceivedComplexity:
+  Max: 10
+
 Rails:
   Enabled: true
 

diff --git a/app/services/foreman_cve_scanner/cve_report_scanner.rb b/app/services/foreman_cve_scanner/cve_report_scanner.rb
@@ -103,8 +103,9 @@ def generate_trivy_entry(entry)
 
     # rubocop:disable Metrics/AbcSize
     def generate_unified_vuls
-      j = @raw_data['scan']
+      raise ::Foreman::Exception, _('Invalid CVE scanner report') unless @raw_data.key?('scan')
 
+      j = @raw_data['scan']
       vuls = {}
       if j.key?('matches') # Grype
         j['matches'].each do |vul|
@@ -119,7 +120,7 @@ def generate_unified_vuls
         end
       else
         Rails.logger.error 'Unsupported cve scanner report format'
-        raise ::Foreman::Exception, _('Invalid report')
+        raise ::Foreman::Exception, _('Unsupported cve scanner report format')
       end
 
       vuls