Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EL9 to packit config #142

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Add EL9 to packit config #142

merged 2 commits into from
Oct 11, 2024

Conversation

nadjaheitmann
Copy link
Collaborator

No description provided.

maximiliankolb
maximiliankolb reviewed Oct 8, 2024
View reviewed changes
.packit.yaml Outdated Show resolved Hide resolved
maximiliankolb
maximiliankolb approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Nadja, diff in README and packit LGTM & I do like a green GHA 🥳

Did someone already review the other commits, perhaps internally or on a different PR? If so, please rebase/squash where necessary and merge. If now, maybe ping Bastian.

@nadjaheitmann
Copy link
Collaborator Author

Did someone already review the other commits, perhaps internally or on a different PR? If so, please rebase/squash where necessary and merge. If now, maybe ping Bastian.

@ofedoren actually had a quick look at my Zeitwerk change. But I dod some more changes to it since then :)

@nadjaheitmann nadjaheitmann force-pushed the update_packit branch 2 times, most recently from e9b4899 to f35e001 Compare October 11, 2024 14:12
m-bucher
m-bucher approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member

@m-bucher m-bucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. If the pipeline is green, feel free to merge it.

@nadjaheitmann nadjaheitmann merged commit d1cb5ef into master Oct 11, 2024
15 checks passed
@nadjaheitmann nadjaheitmann deleted the update_packit branch October 11, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-bucher m-bucher m-bucher approved these changes

@maximiliankolb maximiliankolb maximiliankolb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nadjaheitmann @m-bucher @maximiliankolb