Update actions_subtotal.class.php #419
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made at devcamp, seen with John. When you use the "hide inner lines" option, all rows are hidden even if they are not included in a title (and subtotal) block. This PR fix it.
Comment on lines
+2255
to
+2258
| $hasParentTitle = TSubtotal::getParentTitleOfLine($object, $line->rang); | ||
| if (empty($hasParentTitle) && empty(TSubtotal::isModSubtotalLine($line))) { // cette ligne n'est pas dans un titre => on l'affiche | ||
| $TLines[] = $line; | ||
| } |
There was a problem hiding this comment.
Attention la ligne peut potentiellement être compté 2 fois il faut que la condition suivante soit elseif net non juste if
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made at devcamp, seen with John.
When you use the "hide inner lines" option, all rows are hidden even if they are not included in a title (and subtotal) block.
This PR fix it.