Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fork of StylePile fixing Gradio deprecated syntax #280

Draft
wants to merge 2 commits into
base: extensions
Choose a base branch
from

Conversation

samfisherirl
Copy link

@samfisherirl samfisherirl commented Feb 13, 2024

Info

Checklist:

  • I have read the Readme.md
  • The description is written in English.
  • The index.json and extension_template.json have not been modified.
  • The entry is placed in the extensions directory with the .json file extension.
To create a public link, set `share=True` in `launch()`.
WARNING:py.warnings:D:\sd-webuiDEV\stable-diffusion-webui-dev\extensions\StylePile\scripts\StylePile.py:412: GradioDeprecationWarning: The `style` method is deprecated. Please set these arguments in the constructor instead.
  gr.Gallery(value=ResultDirectionImages, show_label=False).style(

WARNING:py.warnings:D:\sd-webuiDEV\stable-diffusion-webui-dev\extensions\StylePile\scripts\StylePile.py:412: GradioDeprecationWarning: The 'grid' parameter will be deprecated. Please use 'columns' in the constructor instead.
  gr.Gallery(value=ResultDirectionImages, show_label=False).style(

this is a fork of https://github.com/some9000/StylePile

Above are errors present in the code for the last 8 months and the github creator hasn't responded to any issues or pulls in that time.

after waiting a number of months for the original creator to respond to outreach, I've made the adjustments to the code myself. The above warnings were present ~1 year ago on initial merge. I have not been able to get in contact with them during that time.

the small adjustments to line 412-425 of StylePile.py satisfies the Gradio deprecated syntax issues and works as expected.

Im open to any suggestions such as including the users name in the extension name to ensure they get the full credit deserved.

@w-e-w
Copy link
Collaborator

w-e-w commented Feb 13, 2024

you do realize that just uploading a file to the root does not effects the file that is not in the root right?
image


there's a difference between deprecation warning and Error
a warning is just a warning which we should be something that you fix as soon as possible (which I can see hasn't been the case), but it doesn't actually break anything
I'm not sure but this would likely be an actual issue /error when we upgrade to gradio4

currently I'm not sure if I should redirect the URL (merge this PR)

do you intend to continue developing and maintain an extension?

@w-e-w
Copy link
Collaborator

w-e-w commented Feb 13, 2024

@some9000 are you still around

@w-e-w w-e-w marked this pull request as draft March 11, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants