Merge pull request #16151 from AUTOMATIC1111/dora-fix

Possible fix of wrong scale in weight decomposition
AUTOMATIC1111 · Jul 6, 2024 · 372a8e0 · 372a8e0
2 parents b8c3664 + bfbca31
commit 372a8e0
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/extensions-builtin/Lora/network.py b/extensions-builtin/Lora/network.py
@@ -204,10 +204,12 @@ def finalize_updown(self, updown, orig_weight, output_shape, ex_bias=None):
         if ex_bias is not None:
             ex_bias = ex_bias * self.multiplier()
 
+        updown = updown * self.calc_scale()
+
         if self.dora_scale is not None:
             updown = self.apply_weight_decompose(updown, orig_weight)
 
-        return updown * self.calc_scale() * self.multiplier(), ex_bias
+        return updown * self.multiplier(), ex_bias
 
     def calc_updown(self, target):
         raise NotImplementedError()