Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GroundMapping: maximumRange=-1 isn't a valid action #878

Closed
Star-Feel opened this issue Dec 19, 2024 · 1 comment · Fixed by #892
Closed

GroundMapping: maximumRange=-1 isn't a valid action #878

Star-Feel opened this issue Dec 19, 2024 · 1 comment · Fixed by #892
Assignees
Labels
bug Something isn't working

Comments

@Star-Feel
Copy link

Describe the bug
When using GroundMapping with maximumRange=-1, its behavior is abnormal and it can't get access information normally. However, when maximumRange=1e9, it turns to be normal.

To reproduce
Using GroundMapping module

  1. Set maximumRange=1e9, we can observe sat-target access information.
  2. Set maximumRange=-1, accessOutMsgs.read().hasAccess are always 0.

Expected behavior
When maximumRange=-1, the output '1' in hasAccess should be not less than the one when maximumRange=1e9

Screenshots

Desktop (please complete the following information):

  • OS: WSL
  • Version: 2.3.26.0
  • Python version: 3.11.10

Additional context
In basilisk/src/simulation/environment/groundMapping/groundMapping.cpp, I found that the function checkInstrumentFOV() (line 188), if ((boresightNormalProj >= 0) && (boresightNormalProj <= this->maximumRange)){, doesn't consider the -1 case, which is necessary for the access computation. It is possible that the problem here is causing the above bug.

@schaubh
Copy link
Contributor

schaubh commented Dec 21, 2024

Thanks for the feedback. We'll look into that.

@schaubh schaubh self-assigned this Dec 30, 2024
@schaubh schaubh added the bug Something isn't working label Dec 30, 2024
@schaubh schaubh added this to Basilisk Dec 30, 2024
@schaubh schaubh moved this to 🏗 In progress in Basilisk Dec 30, 2024
@schaubh schaubh linked a pull request Dec 30, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Basilisk Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants