maximumRange not properly considered in groundMapping module #892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le is less than 0
Check now if the range is large, very small (yield negative result) or -1 (default behavior where range is not considered)
schaubh
force-pushed
the
feature/issue_878_groundMapping
branch
from
11904fc to
ff2e328
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The method
checkInstrumentFOV()was not properly respecting the default value ofmaximumRangebeing -1.0 which should result in the range not being considered. This branch corrects this issue.Verification
The unit test is updated to check if the target is in range by setting
maximumRangeto default value (-1), a very small value (no target in range) and a very large maximum range value.Documentation
Updated release notes.
Future work
None