WIP Fix Eigen SWIG typemaps from memory leaks #449
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juan-g-bonilla
force-pushed
the
prototype/swig-eigen-leak-fix
branch
from
62d6907 to
11eab77
Compare
|
WIP replaced by #500 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
WIP Added reference decreasers in SWIG Eigen typemaps to try to correctl leaks.
Verification
Existing tests for SWIG Eigen typemaps + manual checking to see if less leaks appear now (TBD)
Future work
Carefully review other SWIG typemaps to ensure we are counting our references properly if more leaks appear related to matrices and vectors.