Update Basilisk for latest support software #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schaubh
added
bug
joaogvcarneiro
requested changes
Oct 8, 2023
src/fswAlgorithms/sensorInterfaces/TAMSensorData/_UnitTest/test_tamComm.py
Outdated
Show resolved
Hide resolved
This addresses errors that appeared when calling some spice commands.
Newer version of matplotlib is more strict in correct uses of brackets in TeX
…to flatten a nested list
With the latest version of numpy this error appears Conversion of an array with ndim > 0 to a scalar is deprecated, and will error in future. These fixes correct this issue and pytest runs again without lots of depreciation warnings.
schaubh
force-pushed
the
feature/BSK-453_update_support
branch
from
6a76711 to
bdf4faa
Compare
schaubh
changed the title
joaogvcarneiro
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While Basilisk would compile with the latest python packages and Xcode (v15), at run time errors or warning of deprecation would appear. In particular, this PR addresses
The macOS
cspicelibrary was rebuilt with Xcode 15 and now the spice errors are gone. I checked for backwards compatibility with Xcode 14 and all was good.This PR fixes all the plotting label strings that contained TeX errors. Before matplotlib closed missing brackets with TeX silently, but now it is throwing an error. All TeX strings are now correct.
Finally, test scripts were updated to be fully compliant with the latest numpy.
Verification
Did a clean build and ran full suite of
pytestwith the latest version ofpytest. All tests are passing again without failures, warnings or depreciations.Documentation
Updated release notes on the newly compiled version of
cspicefor macOS.Future work
None