Increase number css measurements csswls

[patkenneally]

• Tickets addressed: bsk-467 Number of CSS measurements not equal to number of CSS devices #467
• Review: By commit
• Merge strategy: Merge (no squash)

Description

The #MAX_N_CSS_MEAS define is set to 8. The cssWls module calls a memset ☹️ on line 90 in computeWlsResiduals(), which computes the size of memory to set to 0x0 from the number of coarse sun sensors. The residuals variable which is being set has a size of 8 x double. If one has more than 8 coarse sun sensors then the memset will stomp more than 8 x double amount of memory. Many spacecraft employ more than 8 CSS and therefore the filter would expect to compute more than 8 measurement residuals. This PR changes the max number of measurements to be the same value as the max number of CSS.

Verification

CI runs successfully.

Documentation

None needed, none invalidated.

Future work

NA

[schaubh]

Good catch. But, shouldn't there be a warning in Reset_cssWlsEst(), when we read in the CSS config message, if the nCSS variable is larger than MAX_NUM_CSS_SENSORS? Right now we are failing silently? I recommend we ensure nCSS is less than MAX_NUM_CSS_SENSORS or we use the BSK_ERROR statement to warn the user?

[schaubh]

I would add a check in the module reset function to ensure nCSS is not larger than the maximum allowable number of CSS?