Feature/doc fixes #473
Merged
Feature/doc fixes #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schaubh
added
bug
patkenneally
approved these changes
Oct 30, 2023
Updated the module and fixed the unit test to run again.
Found old msg naming strings that were not used, updated documentation strings to not use MsgName at the end, removed old commented out code that was left over from the BSK v1 to v2 migration
Cleaned up the python code in places where it referred to BSK-v1 message naming. Fixed minor grammar typos.
schaubh
force-pushed
the
feature/doc_fixes
branch
from
30f6b62 to
7f27689
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Found more outdated documentation that uses BSK-v1 naming of messages, included un-used module msg name variables, and small associated typos. This PR fixes all the old
...MsgNamevariables found in TeX, python, RST and module files.Verification
All unit and integrated tests pass.
Documentation
TeX documents were rebuilt to be current. All documentation built without issues.
Future work
None.