Bsk 474/fix drag effector #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LorenzzoQM
force-pushed
the
BSK-474/Fix-drag-effector
branch
from
e12e97f to
011e7d9
Compare
schaubh
requested changes
Nov 2, 2023
src/simulation/dynamics/facetDragEffector/_UnitTest/test_unitFacetDrag.py
Outdated
Show resolved
Hide resolved
LorenzzoQM
force-pushed
the
BSK-474/Fix-drag-effector
branch
from
011e7d9 to
6109e77
Compare
schaubh
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the drag torque calculation, where a negative sign was missing. Now, the torque is calculated as$T = -F\times r$ .
Verification
The unit test was also updated to test the drag torque.
Documentation
N/A
Future work
N/A