Feature/487 thruster platform state #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schaubh
requested changes
Nov 16, 2023
There was a problem hiding this comment.
overall good, but the module was using the old way of making BSK C modules. I updated the module code files, and the unit test python file, to use the new way of making C modules. I pushed the commits with label [squash] to your branch. Please integrate these changes.
src/fswAlgorithms/effectorInterfaces/thrusterPlatformState/thrusterPlatformState.c
Outdated
Show resolved
Hide resolved
|
Done with reviews, pushed some simple change requests.
Blue skies, Dr. Schaub
[http://hanspeterschaub.info/pics/SAES-logo.png] Hanspeter Schaub, Ph.D.
Schaden Leadership Chair
Professor and Chair of Smead Aerospace Engineering Sciences Department
Smead Fellow
LASP Senior Associate for Engineering Research and Education
Director of the Autonomous Vehicle Systems (AVS) Laboratory
Fellow of AIAA and AAS
Address: Aerospace Engineering Sciences (ASEN) Department
Colorado Center for Astrodynamics Research (CCAR)
3775 Discovery Drive, 429 UCB
University of Colorado
Boulder, CO 80303-0429
Office: AERO 224N
Phone: +1 (303) 492-2767
Email: ***@***.******@***.***>
Web: http://hanspeterschaub.info<http://hanspeterschaub.info/>
On Nov 15, 2023, at 7:05 PM, Riccardo Calaon ***@***.***> wrote:
@rcalaon<https://github.com/rcalaon> requested your review on: #488<#488> Feature/487 thruster platform state.
—
Reply to this email directly, view it on GitHub<#488 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AVGSPDMXCGIVUDKOOPNUOQDYEVKE3AVCNFSM6AAAAAA7NIJZYKVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJQHE3TGNZRGI2TQOI>.
You are receiving this because your review was requested.Message ID: ***@***.***>
|
rcalaon
force-pushed
the
feature/487-thrusterPlatformState
branch
from
1262bca to
1845309
Compare
rcalaon
force-pushed
the
feature/487-thrusterPlatformState
branch
from
1845309 to
8e8d464
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This module reads in the current angles of the thruster-platform assembly, modeled as a
SpinningBodyTwoDOFStateEffector. This allows to map the thruster configuration info from the platform frame to the body frame. Commits 1 through 3 incrementally build the module. Commit 4 contains the unit test. Commit. 5 contains the documentation and the updated release notes.Verification
A unit test is provided to check the correctness of the output agains different input angle states.
Documentation
Documentation is provided to explain how to correctly set up the module, with input and output messages.
Future work
No future work is foreseen at the moment.