-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/506 set data buffer method in storage unit #507
Merged
LorenzzoQM
merged 4 commits into
develop
from
feature/506_setDataBuffer_method_in_storageUnit
Nov 23, 2023
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
111d0dc
setDataBuffer method added to dataStorageUnitBase
LorenzzoQM 7578479
Method added to simple and partitioned StorageUnit
LorenzzoQM 672b908
Updated tests for setDataBuffer method
LorenzzoQM 9b5dc30
Added description of setDataBuffer to .rst files and ReleaseNotes
LorenzzoQM File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realize that this has already been merged, but maybe after the break, this can be changed to use the precise width type
int64_t
or evenuint64_t
if your semantics demand it. We should prefer precise width types for any integer types larger thanint
. The bit size of integral types is not guaranteed across platforms/compilers. It benefits us to er on the side of guarantee. You can see (for the large majority) this attempt throughout the code base to useint32_t
,int64_t
, and the unsigned versions.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Howdy @LorenzzoQM , @patkenneally makes some good points here about the use of
int64_t
, etc. Could you please create a small branch next week to address his feedback? I'll respond to review request quickly so it doesn't slow down your research tasks.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure! I will address the comments as soon as possible. Thank you for the feedback, @patkenneally.