Terminate at time of terminal events instead of a step later #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Realized this PR also applied some formatting to imports in the file, can be undone if desired to keep the PR clean. |
schaubh
approved these changes
Dec 15, 2023
schaubh
force-pushed
the
bugfix/544-terminate
branch
from
b55f1cb to
6c41766
Compare
schaubh
force-pushed
the
bugfix/544-terminate
branch
from
6c41766 to
de11de8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Break before executing the simulation if a terminal event was triggered.
Verification
Current tests still pass.
Documentation
Added release note.
Future work
None.