Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/bsk 656 tweak prescribed linear translation #657

Merged

Conversation

leahkiner
Copy link
Contributor

@leahkiner leahkiner commented Apr 1, 2024

  • Tickets addressed: bsk-656
  • Review: By commit
  • Merge strategy: squash and merge

Description

This PR addresses a few changes that should be made to the existing prescribedLinearTranslation module to match the current changes being applied to the prescribedRotation1DOF module. These changes include:

  1. Updating release notes to point out the renamed module variable coastOptionBangDuration and the associated setter and getter methods.
  2. Add const keyword to the module setter function parameters
  3. Fixing up comments

Verification

N/A

Documentation

N/A

Future work

N/A

@leahkiner leahkiner added the refactor Clean up with no new functionality label Apr 1, 2024
@leahkiner leahkiner requested a review from schaubh April 1, 2024 21:56
@leahkiner leahkiner self-assigned this Apr 1, 2024
@leahkiner leahkiner linked an issue Apr 1, 2024 that may be closed by this pull request
@leahkiner leahkiner force-pushed the refactor/bsk-656-tweak-prescribedLinearTranslation branch from 8a3f86c to 72a530e Compare April 3, 2024 15:45
@leahkiner leahkiner merged commit 7ddae30 into develop Apr 3, 2024
2 checks passed
@leahkiner leahkiner deleted the refactor/bsk-656-tweak-prescribedLinearTranslation branch April 3, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Clean up with no new functionality
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Small changes to prescribedLinearTranslation module
2 participants