Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/n dof spinning bodies #660

Merged
merged 4 commits into from
May 13, 2024
Merged

Conversation

joaogvcarneiro
Copy link
Contributor

Description

This PR adds a new effector to Basilisk that simulates a chain of rotating rigid bodies up to any number of degrees of freedom. The first commit adds the module files, the second adds the test file, the third adds the documentation, and the fourth updates the release notes.

Verification

A Python test file is added that checks energy and momentum conservation.

Documentation

A .rst file explains the module and how to set it up. The mathematical derivation can be found in a paper linked in the documentation page.

Future work

A scenario that uses this module is in the works.

@joaogvcarneiro joaogvcarneiro added the enhancement New feature or request label Apr 3, 2024
@joaogvcarneiro joaogvcarneiro self-assigned this Apr 3, 2024
@joaogvcarneiro joaogvcarneiro force-pushed the feature/nDOFSpinningBodies branch from 6b7df7d to cce35d3 Compare April 3, 2024 16:46
@joaogvcarneiro joaogvcarneiro linked an issue Apr 3, 2024 that may be closed by this pull request
@joaogvcarneiro joaogvcarneiro force-pushed the feature/nDOFSpinningBodies branch from cce35d3 to 7879d81 Compare April 4, 2024 19:57
Copy link
Contributor

@schaubh schaubh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good branch! Just a few quick things to address. Almost there. :-)

@joaogvcarneiro joaogvcarneiro force-pushed the feature/nDOFSpinningBodies branch from 7879d81 to de94029 Compare April 19, 2024 17:49
@joaogvcarneiro joaogvcarneiro requested a review from a team as a code owner April 19, 2024 17:49
@joaogvcarneiro joaogvcarneiro requested a review from schaubh April 19, 2024 17:49
@joaogvcarneiro joaogvcarneiro force-pushed the feature/nDOFSpinningBodies branch from de94029 to 1ab9cbc Compare May 6, 2024 17:17
@schaubh
Copy link
Contributor

schaubh commented May 7, 2024

@patkenneally , I think @joaogvcarneiro is holding up pushing this to give you a chance to review. Is this still your intend?

@joaogvcarneiro joaogvcarneiro merged commit 873296d into develop May 13, 2024
2 checks passed
@joaogvcarneiro joaogvcarneiro deleted the feature/nDOFSpinningBodies branch May 13, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add spinningBodiesNDOF
2 participants