-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/n dof spinning bodies #660
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaogvcarneiro
force-pushed
the
feature/nDOFSpinningBodies
branch
from
April 3, 2024 16:46
6b7df7d
to
cce35d3
Compare
Closed
joaogvcarneiro
force-pushed
the
feature/nDOFSpinningBodies
branch
from
April 4, 2024 19:57
cce35d3
to
7879d81
Compare
schaubh
requested changes
Apr 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good branch! Just a few quick things to address. Almost there. :-)
...n/dynamics/spinningBodies/spinningBodiesNDOF/_UnitTest/test_spinningBodyNDOFStateEffector.py
Outdated
Show resolved
Hide resolved
src/simulation/dynamics/spinningBodies/spinningBodiesNDOF/spinningBodyNDOFStateEffector.h
Outdated
Show resolved
Hide resolved
joaogvcarneiro
force-pushed
the
feature/nDOFSpinningBodies
branch
from
April 19, 2024 17:49
7879d81
to
de94029
Compare
schaubh
approved these changes
Apr 19, 2024
joaogvcarneiro
force-pushed
the
feature/nDOFSpinningBodies
branch
from
May 6, 2024 17:17
de94029
to
1ab9cbc
Compare
@patkenneally , I think @joaogvcarneiro is holding up pushing this to give you a chance to review. Is this still your intend? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new effector to Basilisk that simulates a chain of rotating rigid bodies up to any number of degrees of freedom. The first commit adds the module files, the second adds the test file, the third adds the documentation, and the fourth updates the release notes.
Verification
A Python test file is added that checks energy and momentum conservation.
Documentation
A .rst file explains the module and how to set it up. The mathematical derivation can be found in a paper linked in the documentation page.
Future work
A scenario that uses this module is in the works.