Feature/667 Message payload C array types

[sassy-asjp]

• Tickets addressed: closes Unable to access elements of custom message if they are an array of uint16/int16 #667
• Review: By commit
• Merge strategy: Merge (no squash)

Description

The wrapping for C arrays was modified to support more integer types, and fix incorrect handling of integers as floats for 2D arrays.

A message definition used only for unit tests was added.

Verification

Unit tests have been included.

Documentation

There is no documentation change required.

Future work

None.

[sassy-asjp]

Not sure why the Linux tests failed. I even tried inside docker Ubuntu 20.04 using pytest-xdist and could not reproduce locally

[schaubh]

I'll pull this branch and see if it works on my macOS system. Don't have further info right now on the Linux CI failures.

[sassy-asjp]

So I think the problem was in some situations (old python?? old swig??) the wrapping for the stdint fixed width types like uint64_t were guessed incorrectly. I was able to reproduce in Docker by trying to follow the GitHub action script line by line. Explicitly defining the wrappings for the stdint types fixed it.

I missed the failure originally since the build passed, however the problem was in build not test, just not reported correctly as #552

[juan-g-bonilla]

Thank you very much @sassy-asjp for this PR. I think it's exactly the right approach and I appreciate the nice test. However, I do have a couple suggestions to make the changes even better. These suggestions are not really about the code you've written, but about improving the macros wrt how they currently stand. It'd be great if you could take a look.

[sassy-asjp]

@juan-g-bonilla I went through and thought about the python object reference counts and added some Py_DECREF where I thought appropriate.

[juan-g-bonilla]

LGTM

[schaubh]

thanks for the contribution. I pulled your branch and did a clean build and didn't encounter any issues with all our tests (including opNav) that are not tested on the CI.

Regarding closing this PR, could you please add a brief release notes statement in
basilisk/docs/source/Support/bskReleaseNotes.rst

You can add a bullet under the current beta release notes under the line

Version |release|
-----------------

[schaubh]

all variables need to have a doxygen comment string. Right now the documentation build throws lots of warnings.

[patkenneally]

If okay with others, I'd like a little more time to also review this PR.

[schaubh]

@sassy-asjp , we are ready to push this branch to BSK develop. Another branch was pushed recently. Could you pease rebase and resolve any conflict in the release notes RST file? Thanks. I can then close this PR.

[sassy-asjp]

@schaubh Done