Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N-Axis Effector Scenarios #677

Merged
merged 5 commits into from
Jun 4, 2024
Merged

N-Axis Effector Scenarios #677

merged 5 commits into from
Jun 4, 2024

Conversation

joaogvcarneiro
Copy link
Contributor

Description

Added two new scenarios that showcase the capabilities of the N-axis effector. One scenario simulates a flexible panel and the other simulates a robotic arm.

Verification

Added two tests that call these scenarios.

Documentation

Documentation is built for both scenarios.

Future work

N/A.

@joaogvcarneiro joaogvcarneiro added the enhancement New feature or request label May 6, 2024
@joaogvcarneiro joaogvcarneiro self-assigned this May 6, 2024
@joaogvcarneiro joaogvcarneiro force-pushed the feature/scenario_NDoF branch 2 times, most recently from 21e8e77 to ad2f808 Compare May 15, 2024 18:21
@joaogvcarneiro joaogvcarneiro marked this pull request as ready for review May 15, 2024 18:26
@joaogvcarneiro joaogvcarneiro requested a review from a team as a code owner May 15, 2024 18:26
@joaogvcarneiro joaogvcarneiro force-pushed the feature/scenario_NDoF branch from ad2f808 to 4f94bbc Compare May 15, 2024 18:34
@joaogvcarneiro joaogvcarneiro linked an issue May 15, 2024 that may be closed by this pull request
Copy link
Contributor

@schaubh schaubh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool scenarios. I think they both illustrate what we discussed for the focus of the paper. I made a series of edits and fixes that I pushed to origin with Isquash labels. Please review and squash with your prior commits.

Overall very nice. I did change the time step to speed up the sim run-times. No change in the visual plots. Also, with these time steps Vizard is playing back the file at a rate where the motion is nice to observe.

Change the stiffness and damping of the panel, we now have deflections up to around 10˚. Very cool to see in Vizard as well as your plots.

examples/scenarioRoboticArm.py Outdated Show resolved Hide resolved
examples/scenarioRoboticArm.py Outdated Show resolved Hide resolved
examples/scenarioRoboticArm.py Outdated Show resolved Hide resolved
examples/scenarioRoboticArm.py Outdated Show resolved Hide resolved
examples/scenarioRoboticArm.py Outdated Show resolved Hide resolved
examples/scenarioFlexiblePanel.py Outdated Show resolved Hide resolved
@joaogvcarneiro joaogvcarneiro force-pushed the feature/scenario_NDoF branch from 2f2c4e7 to c27dd53 Compare May 17, 2024 20:23
@joaogvcarneiro joaogvcarneiro force-pushed the feature/scenario_NDoF branch from c27dd53 to 006ce4b Compare May 27, 2024 18:54
@joaogvcarneiro joaogvcarneiro force-pushed the feature/scenario_NDoF branch 2 times, most recently from 812f5a8 to 273a6eb Compare June 4, 2024 16:45
@joaogvcarneiro joaogvcarneiro requested review from schaubh June 4, 2024 17:31
Copy link
Contributor

@schaubh schaubh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure saveFile command is commented out by default. Otherwise good to go. Did a test build of documentation and all worked well.

examples/scenarioFlexiblePanel.py Outdated Show resolved Hide resolved
@joaogvcarneiro joaogvcarneiro force-pushed the feature/scenario_NDoF branch from 273a6eb to a0a3f02 Compare June 4, 2024 19:16
@joaogvcarneiro joaogvcarneiro merged commit 3dda328 into develop Jun 4, 2024
3 checks passed
@joaogvcarneiro joaogvcarneiro deleted the feature/scenario_NDoF branch June 4, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add N-DoF scenario
2 participants