Set _use_math_macro in compiler for windows #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaogvcarneiro
approved these changes
May 13, 2024
schaubh
force-pushed
the
feature/target-use-math-macros-from-cmake
branch
from
b1e3c4d to
333e734
Compare
On Windows to make certain math macros like M_PI
schaubh
force-pushed
the
feature/target-use-math-macros-from-cmake
branch
from
333e734 to
c4a7301
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Lifting this branch from the LASP version of Basilisk to regular Basilisk repo. The original author is @patkenneally.
On Windows some math definitions are not included by default unlike macOS and Linux compilers. Instead of including the math library in each module
*.hfile individually, this change includes the math definitions file within the build system for the Windows platform.Verification
Clean build without warnings and all tests passed.
Documentation
Documentation built without issues.
Future work
None