Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/unused includes #688

Merged
merged 2 commits into from
May 16, 2024
Merged

Feature/unused includes #688

merged 2 commits into from
May 16, 2024

Conversation

schaubh
Copy link
Contributor

@schaubh schaubh commented May 16, 2024

  • Review: By commit
  • Merge strategy: Merge (no squash)

Description

This branch is lifted from the LASP fork of Basilisk. Original changes were done by @patkenneally.

Some of the C/C++ code was including *.h files that were no longer needed. This branch removes all these
unused includes.

Verification

Did a clean build that had no warnings. All tests passed.

Documentation

N/A

Future work

None

@schaubh schaubh added the refactor Clean up with no new functionality label May 16, 2024
@schaubh schaubh requested review from patkenneally and Mark2000 May 16, 2024 13:52
@schaubh schaubh self-assigned this May 16, 2024
@schaubh schaubh requested a review from a team as a code owner May 16, 2024 13:52
@schaubh schaubh merged commit e2f1e39 into develop May 16, 2024
2 checks passed
@schaubh schaubh deleted the feature/unused_includes branch May 16, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Clean up with no new functionality
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants