Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVS Eigen Library Identity MRP Fix #694

Merged
merged 1 commit into from
May 21, 2024
Merged

Conversation

andrewmorell
Copy link
Contributor

@andrewmorell andrewmorell commented May 17, 2024

  • Tickets addressed: bsk-693
  • Review: By commit
  • Merge strategy: Merge (no squash)

Description

The Identity() method for AVS Eigen MRP initialization was changed to appropriately create an identity rotation MRP instead of an identity quaternion which was the bug.

Verification

This changes passes build checks.

Documentation

No documentation was created or invalidated.

Future work

NA

@andrewmorell andrewmorell added the bug Something isn't working label May 17, 2024
@andrewmorell andrewmorell requested a review from a team as a code owner May 17, 2024 21:16
@schaubh schaubh self-assigned this May 21, 2024
@schaubh schaubh self-requested a review May 21, 2024 13:16
Copy link
Contributor

@schaubh schaubh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a unit test for the new functionality and release notes

@schaubh schaubh merged commit 4ef8053 into develop May 21, 2024
2 checks passed
@schaubh schaubh deleted the 693-avs-eigen-mrp-identity branch May 21, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

AVS Eigen library's MRP Identity() method returns identity quaternion rotation
2 participants