Update conanfile #699
Merged
Update conanfile #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schaubh
force-pushed
the
feature/conan_file_updates
branch
2 times, most recently
from
bdd4e5e to
fbcf614
Compare
|
Thanks for the feedback @joaogvcarneiro , I'll re-run this on my side as well. If you have BSK compiled with opNav set to True, then the opNav scenarios do get called one by one. That might be what you are seeing. It launches the app about 8-10 times. |
|
Just re-built this branch, ran all test and built documentation. Yes, if you have the |
joaogvcarneiro
approved these changes
May 28, 2024
Previously <ifstream> was being included by happenstance. Instead, includes used in the file should all be explicit.
Checking the return code will ensure that if the subprocess fails then the conanfile fails. This is correct and as a nice side effect it ensures that the github action step fails when the build fails. Additionally, os.system is not the recommend method to run a subprocess.
schaubh
force-pushed
the
feature/conan_file_updates
branch
from
fbcf614 to
f53e010
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This original update is lifted from the LASP fork of Basilisk and was authored by @patkenneally. The branch
added release notes and documentation updates.
Here the Eigen library is updated to 3.4.0 and OpenCV to 4.5.5.
Verification
A clean build was done with a fresh
.conandirectory and Basilisk built without issues.All unit tests passed.
Documentation
Added release notes and updated the camera module RST documentation to point to the OpenCV 4.5.5
documentation.
Future work
None