Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add interpolation functions #719

Merged
merged 8 commits into from
Jun 14, 2024
Merged

Feature/add interpolation functions #719

merged 8 commits into from
Jun 14, 2024

Conversation

leahkiner
Copy link
Contributor

  • Tickets addressed: bsk-718
  • Review: By commit
  • Merge strategy: Merge (no squash)

Description

PR is brought over from LASP-BSK fork. This PR adds linear and bilinear interpolation functions to the utilities folder.

Verification

Google tests are written for each method to check their functionality.

Documentation

N/A

Future work

N/A

@leahkiner leahkiner added the enhancement New feature or request label Jun 10, 2024
@leahkiner leahkiner requested a review from schaubh June 10, 2024 22:28
@leahkiner leahkiner self-assigned this Jun 10, 2024
@leahkiner leahkiner requested a review from a team as a code owner June 10, 2024 22:28
@leahkiner leahkiner linked an issue Jun 10, 2024 that may be closed by this pull request
Add linear and bilinear interpolation functions to the utilities folder #718
Closed
@schaubh
Copy link
Contributor

schaubh commented Jun 13, 2024

The documentation wasn't building for 2 issues.

  1. The *.hpp files were not being included when gather up BSK files, this is now corrected.
  2. The sphinx conf.py script was gathering up all related files. However, with the logic it would include files if one file name was contained within the other file name. This was the case here with linearInterpolation.hpp and bilinearInterpolation.hpp. A commit now addresses this to ensure the files names must match.

The documentation now builds properly and these two new files are shown in the documentation.

schaubh
schaubh approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@schaubh schaubh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed some commits to ensure the documentation now includes hpp files, and it isn't confused if one file name is contained in another file name.

@schaubh schaubh force-pushed the feature/add-interpolation-functions branch from 4a9dc43 to 98dd1ce Compare June 13, 2024 13:24
@schaubh schaubh requested a review from Mark2000 June 13, 2024 13:31
Mark2000
Mark2000 approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@Mark2000 Mark2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to conf.py look good.

leahkiner and others added 8 commits June 13, 2024 11:21
@leahkiner leahkiner force-pushed the feature/add-interpolation-functions branch from 98dd1ce to 81578c7 Compare June 13, 2024 17:25
@schaubh schaubh merged commit 15014b4 into develop Jun 14, 2024
3 checks passed
@schaubh schaubh deleted the feature/add-interpolation-functions branch June 14, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schaubh schaubh schaubh approved these changes

@Mark2000 Mark2000 Mark2000 approved these changes

Assignees

@leahkiner leahkiner

Labels
enhancement New feature or request
Projects
Basilisk
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add linear and bilinear interpolation functions to the utilities folder
3 participants
@leahkiner @schaubh @Mark2000