Have effector receive hub state and parameter names automatically #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schaubh
force-pushed
the
feature/auto-connect-effector
branch
from
d91f40b to
a72e95a
Compare
schaubh
force-pushed
the
feature/auto-connect-effector
branch
from
d8c0ce5 to
ad13f6a
Compare
schaubh
force-pushed
the
feature/auto-connect-effector
branch
from
ad13f6a to
637569e
Compare
schaubh
force-pushed
the
feature/auto-connect-effector
branch
3 times, most recently
from
39d2102 to
754e6a7
Compare
schaubh
force-pushed
the
feature/auto-connect-effector
branch
2 times, most recently
from
f732143 to
07169b4
Compare
andrewmorell
approved these changes
Aug 19, 2024
src/simulation/dynamics/GravityGradientEffector/GravityGradientEffector.cpp
Show resolved
Hide resolved
src/simulation/dynamics/Thrusters/thrusterStateEffector/thrusterStateEffector.cpp
Show resolved
Hide resolved
|
Ah I went to go make the quick indentation changes myself and it turns out it is github's UI showing tabs different than four spaces. In my IDEs it looks normal, not sure whether this is worth us changing at the moment. |
andrewmorell
force-pushed
the
feature/auto-connect-effector
branch
from
07169b4 to
7962373
Compare
update spacecraft and spacecraftSystem to automatically set the hub state names within the dynamic effector
If the stateName variable is an empty string then this error message does not make this apparent. Edited the warning string to make this clearer.
These class variables are set when the addDynamicEffector() method is called.
The one unit test never used addDynamicEffector() to add the thruster to the spacecraft. The script had to be edited to manually set the class state name variables now for the parent rigid body.
update state effectors to register to the state named in the class state name variables
ensure that both spacecraft and spacecraftSystem create properties from these variables. This will enable us next add effectors property names that are set automatically when effectors are added to a spacecraft.
Pull these now from from the effector variables. SpacecraftSystem already did this, but spacecraft wasn't updated apparently.
Need to be added to dynamic Effector base class
spacecraft(System) has been updated to add these to state effectors added to the spacecraft
They now pull the auto-assigned property names from the parent rigid body (i.e. spacecraft for now)
This just cause some odd HTML code to be displayed. There variables don't have units, so no need to designate it with --
This reduces code duplication and provides one place to add new names
Some methods provide the select parent body kinematic states. However, the method was then pulling these same states from the state engine. In this commit this behavior is cleaned up such that only the provided kinematic states are being used.
schaubh
force-pushed
the
feature/auto-connect-effector
branch
from
7962373 to
3b62a23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The state and dynamic effector require the State Machine state and parameter names of the spacecraft hub.
However, currently these are mostly hard coded when the effector subscribes to the particular states
or parameters from the state machine. A small number have strings that are set and then used to
subscribe.
This branch adds state and parameter names to the state and dynamic effector parent classes such that when
the effector is added to the spacecraft object with
.addDynamicEffector()and.addStateEffectorthe state machine names are set automatically from the spacecraft hub. There are no functional changes
with this branch.
Verification
Did a clean build and ran all tests. Also, the ultimate test here is being able to change a spacecraft
hub state name in python and still be able to run this code. This test completed successfully.
Documentation
Added release notes.
Future work
This branch cleans up the assignment of parent body state and property names to the effectors. Future work
will build on this to add some abilities to add selected state and dynamic effectors to particular other effectors.