Flush vizInterface outputStream buffer when saving to file #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schaubh
requested changes
Oct 29, 2024
jackfox25
force-pushed
the
feature/viz_bufferflush
branch
from
9e996f0 to
cde3ce1
Compare
schaubh
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When saving vizMessages to a binary file through vizInterface, the outputStream buffer was not being emptied fully. This led to early file truncation. Explicitly flushing the buffer after each sim step resolves this issue.
Verification
Manual inspection of saved binaries, using protobuffer test scenario which will be pushed in a future branch.
Documentation
Updated release notes
Future work
None