Refactor/856 refactor facet srp dynamic effector #865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leahkiner
added
bug
leahkiner
force-pushed
the
refactor/856-refactor-facetSRPDynamicEffector
branch
3 times, most recently
from
96cb6b5 to
efbf0b8
Compare
schaubh
requested changes
Dec 5, 2024
src/simulation/dynamics/facetSRPDynamicEffector/facetSRPDynamicEffector.h
Show resolved
Hide resolved
src/simulation/dynamics/facetSRPDynamicEffector/facetSRPDynamicEffector.cpp
Outdated
Show resolved
Hide resolved
src/simulation/dynamics/facetSRPDynamicEffector/facetSRPDynamicEffector.i
Show resolved
Hide resolved
src/simulation/dynamics/facetSRPDynamicEffector/_UnitTest/test_unitFacetSRPDynamicEffector.py
Outdated
Show resolved
Hide resolved
src/simulation/dynamics/facetSRPDynamicEffector/facetSRPDynamicEffector.rst
Show resolved
Hide resolved
leahkiner
force-pushed
the
refactor/856-refactor-facetSRPDynamicEffector
branch
2 times, most recently
from
999c710 to
cd82174
Compare
|
@schaubh This branch is ready for a re-review. I have fixed all of your requested changes. |
leahkiner
force-pushed
the
refactor/856-refactor-facetSRPDynamicEffector
branch
from
cd82174 to
82100a0
Compare
rcalaon
approved these changes
Dec 6, 2024
schaubh
force-pushed
the
refactor/856-refactor-facetSRPDynamicEffector
branch
from
7a3845e to
45d1fec
Compare
schaubh
approved these changes
Dec 9, 2024
The initial facet attitudes are specified relative to the spacecraft body frame dcm_F0B
These variables will be moved to private module variables in one year. Bsk users are given one year to switch to using the provided setters and getters.
leahkiner
force-pushed
the
refactor/856-refactor-facetSRPDynamicEffector
branch
from
45d1fec to
7143d6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
facetSRPDynamicEffectormodule currently has a bug when mapping the facet normal vectors to the spacecraft body frame. The computed DCM from the facet frame to the body frame must be transposed to obtain the correct transformation. Along with fixing this issue, this PR cleans up the module code, unit test, and documentation.A significant change this PR introduces to the module code is the requirement for the user to specify the initial facet attitudes relative to the spacecraft body frame. These DCMs are added to the
FacetedSRPSpacecraftGeometryDatastructure and the vector is calledfacetDcm_F0BList. The second significant change this PR introduces is frame specification for the facet normal vectors and rotation axes. These vectors contained in theFacetedSRPSpacecraftGeometryDataare renamed tofacetNHat_FListandfacetRotHat_FList. As these variables now indicate, these vectors are required to be specified in the facet F frames instead of the spacecraft body frame B.Verification
The unit test for this module is updated to reflect these changes. An additional test is added to verify the SRP torque is correctly calculated.
Documentation
The documentation is updated to reflect these changes.
Future work
N/A