Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance SWIG support for various type arrays #866

Merged
merged 3 commits into from
Dec 6, 2024

Conversation

Natsoulas
Copy link
Contributor

Description

Problem was reproduced using issue #851 posting.

Verification

Problem reproduction with changes resolves issues. Arrays of all the types requested are now supported with swig.

Documentation

No documentation invalidated. Less trouble for users.

Future work

If any more requests for specific types arise, they can easily be added in this fashion.

@Natsoulas Natsoulas added the enhancement New feature or request label Dec 5, 2024
@Natsoulas Natsoulas self-assigned this Dec 5, 2024
@Natsoulas Natsoulas requested a review from a team as a code owner December 5, 2024 02:25
@Natsoulas Natsoulas linked an issue Dec 5, 2024 that may be closed by this pull request
@sassy-asjp
Copy link
Contributor

Thank you! Could you also add it to the src/architecture/messaging/_UnitTest/test_CMsgTypes.py?

@schaubh
Copy link
Contributor

schaubh commented Dec 5, 2024

The macOS build failed because there was a documentation build warning in
bskKnownIssues.rst. Thanks for looking at that.

@Natsoulas Natsoulas force-pushed the enhancement/swig-various-type-array-support branch from ef59b06 to deed0ab Compare December 6, 2024 02:43
@schaubh schaubh self-requested a review December 6, 2024 16:00
Copy link
Contributor

@schaubh schaubh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor RST fix that should be done before closing. I'm approving this PR assuming you can quickly fix this one issue.

docs/source/Support/bskReleaseNotes.rst Outdated Show resolved Hide resolved
@Natsoulas Natsoulas force-pushed the enhancement/swig-various-type-array-support branch from deed0ab to 1f1b150 Compare December 6, 2024 21:57
@Natsoulas Natsoulas force-pushed the enhancement/swig-various-type-array-support branch from 1f1b150 to 55ff06e Compare December 6, 2024 22:10
@Natsoulas Natsoulas merged commit e8f420e into develop Dec 6, 2024
9 checks passed
@Natsoulas Natsoulas deleted the enhancement/swig-various-type-array-support branch December 6, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

No support for uint8_t and unsigned char arrays
3 participants