Fix Windows CI build #868
Merged
Fix Windows CI build #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows CI builds were failing because of an install error. Turns out swig and cmake are now already included this led to the failure. The code is just commented out in case it is needed in the future again.
Mark2000
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Windows CI builds were failing because of an install error. Turns out swig and cmake are now already included this led to the failure. The code is just commented out in case it is needed in the future again.
Verification
CI Windows builds complete without issue again.
Documentation
Not applicable.
Future work
I left the
chocoinstall code in the GitHub action, but commented out. This was done intentionally in case I have to use choco again in the future.