Bug/850 mtbeffector causes issues when interacting with dynmanagersetstate #869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Natsoulas
force-pushed
the
bug/850-mtbeffector-causes-issues-when-interacting-with-dynmanagersetstate
branch
3 times, most recently
from
4a45705 to
b976707
Compare
Natsoulas
force-pushed
the
bug/850-mtbeffector-causes-issues-when-interacting-with-dynmanagersetstate
branch
from
b976707 to
626af16
Compare
Natsoulas
deleted the
bug/850-mtbeffector-causes-issues-when-interacting-with-dynmanagersetstate
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MtbEffectorcauses issues when interacting withdynManager.setState#850Description
Verification
The error was reproduced per the issue #850 instructions and was resolved with the suggested fix of including the swig_eigen.i file in the MtbEffector.i file. This involved running scenarioHohmann.py with the include and ensuring it runs properly when importing the MtbEffector module.
Documentation
No documentation invalidated, or created, merely one less bug in basilisk. Just the release notes and known issues were updated.
Future work
Still need to look into why the dynamics engine is re-swigged for every individual effector/dynamics related class, and whether this is necessary or not. This was the recommendation of the user who posted issue #850.