remove sun sensor gauss markov multiplier #870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Natsoulas
added
bug
schaubh
approved these changes
Dec 9, 2024
Natsoulas
force-pushed
the
bug/remove-sun-sensor-gauss-markov-multiplier
branch
from
ffed43f to
8ca0285
Compare
Natsoulas
force-pushed
the
bug/remove-sun-sensor-gauss-markov-multiplier
branch
from
8ca0285 to
4e24a79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I missed a 1.5x multiplier in my GaussMarkov #862 pr in coarseSunSensor.cpp and so I removed it and adjusted the relevant unit test.
Verification
Issue brought to light in issue #867 and was verified visually, along with the fix.
Documentation
No documentation changes as this ideally would have been included in PR #862
Future work
Possibly refactor sensor models to have more consistent use of GaussMarkov noise model as suggested in issue #867