-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Battery checking should be continuous, not just at steps #59
Comments
Relevant to #74 , once the battery reaches 0 the satellite should remain dead. |
As in a real spacecraft, the power system models remain active even when not explicitly in a sun pointing mode. As long as there is solar incidence on the panels (i.e. positive dot product and not in eclipse), the battery will gain charge according to the incidence angle, distance from sun, and panel area. The charge mode just explicitly sets the attitude controller to point the panels at the sun. |
Thanks for your detailed explanation! |
Describe the bug
The satellite can die then come back alive over the course of a step without triggering failure.
Additional context
Should be fixed by either logging battery and checking at the end of the step, or by adding a continuous terminal event checking battery level. I think the latter is preferable, as it will be less memory intensive (or maybe not, turns out events are time-expensive to check.)
The text was updated successfully, but these errors were encountered: