Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/74 petting zoo #104

Merged
merged 2 commits into from
Dec 21, 2023
Merged

Feature/74 petting zoo #104

merged 2 commits into from
Dec 21, 2023

Conversation

Mark2000
Copy link
Contributor

Description

Closes #74
Closes #97

Refactors reward to be on a per-sat basis.
Implements the PettingZoo parallel api for MARL.

How should this pull request be reviewed?

  • By commit
  • All changes at once

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

One integrated test is flakey because of #59 , which allows the satellite to become a zombie.

  • Unit tests (General Environment only) pytest --cov bsk_rl/envs/general_satellite_tasking --cov-report term-missing tests/unittest
  • Integrated tests (General Environment only) pytest --cov bsk_rl/envs/general_satellite_tasking --cov-report term-missing tests/integration

Test Configuration

  • Python: 3.10.11
  • Basilisk: 2.2.1b0
  • Platform: MacOS

Checklist:

  • My code follows the style guidelines of this project (passes Black, ruff, and isort)
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Commit messages are atomic, are in the form Issue #XXX: Message and have a useful message
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@Mark2000 Mark2000 merged commit 54767c7 into develop Dec 21, 2023
4 checks passed
@Mark2000 Mark2000 deleted the feature/74-petting-zoo branch December 21, 2023 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optionally? report per-satellite rewards Add PettingZoo Api for multiagent sims
2 participants