Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #125: Fix max duration step event evaluation #166

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

Mark2000
Copy link
Contributor

Description

Part of #125

Uses events for max step duration in order to have events that should trigger at

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How should this pull request be reviewed?

  • By commit
  • All changes at once

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Passes Tests

  • Unit tests pytest --cov bsk_rl --cov-report term-missing tests/unittest
  • Integrated tests pytest --cov bsk_rl --cov-report term-missing tests/integration
  • Documentation builds cd docs; make html

Test Configuration

  • Python: 3.11
  • Basilisk: 2.3
  • Platform: Mac

Checklist:

  • My code follows the style guidelines of this project (passes Black, ruff, and isort)
  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation and release notes
  • Commit messages are atomic, are in the form Issue #XXX: Message and have a useful message
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • If I changed an example ipynb, I have locally rebuilt the documentation

Copy link
Contributor

@LorenzzoQM LorenzzoQM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@Mark2000 Mark2000 merged commit 3d3f0c6 into develop Jul 24, 2024
4 checks passed
@Mark2000 Mark2000 deleted the bugfix/125-retask-duration branch July 24, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants